Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for ObjectSpace.undefine_finalizer #1185

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Add specs for ObjectSpace.undefine_finalizer #1185

merged 1 commit into from
Jul 23, 2024

Conversation

peterzhu2118
Copy link
Member

No description provided.

@andrykonchin
Copy link
Member

Thank you!

@andrykonchin andrykonchin merged commit 057c927 into master Jul 23, 2024
28 checks passed
@andrykonchin andrykonchin deleted the pz-undef-finalizer branch July 23, 2024 09:23
@andrykonchin
Copy link
Member

The only additional cases I can see are:

  • check that not one but multiple (that's all) defined finalizers are removed
  • check returned value - it should be object itself
  • what happens when there are no finalizers defined for an object?
  • what happens when athe rgument is a non-reference (e.g. 1) like it's tests in define_finalizer_spec.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterzhu2118 @andrykonchin